Initial implementation#1

Merged

javier-godoy merged 41 commits into

initial-implementation

Aug 14, 2024

mlopezFC commented Jun 4, 2024

Member

No description provided.

mlopezFC added 14 commits

May 22, 2024 15:19


          feat: add initial implementation

51290a1


          build: update to Vaadin 24.4.0.beta5

f6385b9


          fix: use stylename as the state name

b070d2f

fix wrong initial styling caused by the use of style keyword


          fix(demo): fix initial demo values

3d06b5d


          fix: fix issue caused by null style initial value

7305e63


          docs: update license headers

863cfbe


          docs: update license header

ac113f0


          build: fix addon name in scm section

8de2dd2


          build: fix inception year

d8515e1


          build: fix group id

c49c77b


          docs: replace README default values with correct ones


          docs: add javadocs

1719ec2


          fix: use correct default style and content

042f5b6


          test: add basic unit testing

c63e770

mlopezFC requested a review from paodb

June 4, 2024 22:04

javier-godoy requested changes

View reviewed changes

javier-godoy left a comment

Member

See https://github.com/FlowingCode/AddonStarter24/issues/31#issuecomment-2126999803

paodb reviewed

View reviewed changes

pom.xml Outdated

paodb reviewed

View reviewed changes

README.md Outdated

paodb reviewed

View reviewed changes

README.md Outdated

paodb reviewed

View reviewed changes

README.md Outdated

paodb commented Jun 5, 2024

Member

ViewIT line 61 still shows "paper-input"

paodb commented Jun 5, 2024

Member

The add-on name replacement is missing in the issues templates. See https://github.com/FlowingCode/TechnicalDocs/blob/master/addons/checklist-0.md#issue_template

paodb reviewed

View reviewed changes

README.md Outdated

paodb reviewed

View reviewed changes

README.md Outdated

paodb reviewed

View reviewed changes

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHLanguage.java Outdated

paodb reviewed

View reviewed changes

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHLanguagePrism.java Outdated

paodb reviewed

View reviewed changes

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHStyle.java Outdated

paodb reviewed

View reviewed changes

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHStylePrism.java Outdated

paodb reviewed

View reviewed changes

src/test/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SyntaxHighlighterDemoView.java Outdated


          build: use correct group id

ec5cc99

mlopezFC added 5 commits

July 31, 2024 15:52


          feat(demo): add missing @Githubbranch annotation

0c1b4c3


          feat: improve constructors

6a62014

provide a no argument constructor and another one that receives language
and content


          docs: improve javadocs

aff45fd

explain difference with plain SyntaxhHighlighter and add documentation
for no arg constructor


          refactor: use a BaseSyntaxHighlighter class to reuse code

c162ee4


          docs: add missing javadoc

052586f

mlopezFC requested review from javier-godoy and paodb

July 31, 2024 21:20

paodb reviewed

View reviewed changes

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/BaseSyntaxHighlighter.java Outdated

paodb reviewed

View reviewed changes

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/BaseSyntaxHighlighter.java Outdated

paodb commented Aug 5, 2024

Member

Also make sure to update License file taking in consideration https://github.com/FlowingCode/AddonStarter24/blob/master/LICENSE that was recently updated (remove first lines).

paodb reviewed

View reviewed changes

README.md

paodb commented Aug 5, 2024

Member

Also un readme, remove reference to vaadin directory repository https://github.com/FlowingCode/AddonStarter24/pull/39/files

mlopezFC added 4 commits

August 5, 2024 15:58


          fix: use correct property name

01a1de1


          docs: remove initial lines

a65bfb0


          docs: use allowed instead of whitelisted

f09d555


          docs: update the location of the released and snapshot versions

3e67144

mlopezFC requested a review from paodb

August 5, 2024 19:05


          fix: rename wrapLines attribute to wrapLongLines

e02cb60

Rename the wrapLines attribute so it uses the same name as its
javascript counterpart

paodb approved these changes

View reviewed changes

paodb left a comment

Member

Tested it and it all looks good now.

javier-godoy requested changes

View reviewed changes

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHLanguage.java Outdated

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHLanguagePrism.java Outdated

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHStyle.java Outdated

src/main/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SHStylePrism.java Outdated

src/test/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SyntaxHighlighterDemo.java Outdated

src/test/java/com/flowingcode/vaadin/addons/syntaxhighlighter/SyntaxHighlighterPrismDemo.java Outdated

mlopezFC added 6 commits

August 13, 2024 11:31


          refactor: use correct camel case capitalization for SHLanguage class

18fe5f9


          refactor(demo): use multiline text blocks


          refactor: fix camel case capitalization for SHLanguagePrism class

8ec224a


          refactor: use correct camel case capitalization for SHStyle class

05264c0


          refactor: use correct camel case capitalization for SHStylePrism class

9be66ef


          refactor: fix capitalization of getters and setters of SHLanguage

a9842e4

mlopezFC requested a review from javier-godoy

August 13, 2024 14:54

javier-godoy approved these changes

View reviewed changes

javier-godoy merged commit a317c4b into master

javier-godoy deleted the initial-implementation branch

August 14, 2024 12:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet