Initial implementation#1
Conversation
f7530fa to
2c9d302
Compare
There was a problem hiding this comment.
There are several non-atomical commits. Instead of feat: implement A followed by fix: replace A with B just squash it and do feat: implement B, as if you had initially implemented B.
For instance:
refactor: move style file to an add-on specific location
squash with the commit where you commit the file to the other location
refactor(demo): update classnames to be more specific
squash with the commit where you implement the classnames
fix: make a defensive copy of customdrivers map
squash with the commit where you didn't make the defensive copy
fix: update customDrivers iteration on createSharee method
squash with the commit where you implement the iteration
style: remove blank lines
squash with the commit where those blank lines were added
fix: update parameters on executeJs calls
squash with the commit where the executeJs call is added
(and maybe others)
d3f03dc to
ddd0a2a
Compare
2f64cf5 to
41fa28b
Compare
|
I reviewed the addon and everything LGTM |
41fa28b to
f9087d1
Compare
|
LGTM |
| LTR, RTL; | ||
| } | ||
|
|
||
| public String copiedSuccessfully = "Copied successfully"; |
| public String shareText; | ||
|
|
||
| /* By default current page's url */ | ||
| public String shareLink; |
No description provided.