Upgrade to FontAwesome 7 by Sam42R · Pull Request #125 · FlowingCode/FontAwesomeIronIconset

Sam42R · 2026-04-22T19:20:49Z

Summary by CodeRabbit

New Features
- Released Version 6.0.0 with upgraded FontAwesome 7 icon library rendered via vaadin-icon.
- Adds explicit compatibility with Vaadin 24–25.
Chores
- Package/module version updated to 6.0.0 and release notes updated accordingly.

BREAKING CHANGE (refs FlowingCode#116)

coderabbitai · 2026-04-22T19:21:02Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 52eca4cb-7421-4fae-879e-bb900b311d16

📥 Commits

Reviewing files that changed from the base of the PR and between 6aa1441 and 671759c.

⛔ Files ignored due to path filters (1)

src/main/generated/com/flowingcode/vaadin/addons/fontawesome/FontAwesome.java is excluded by !**/generated/**

📒 Files selected for processing (2)

pom.xml
src/main/javascript/font-awesome-iron-iconset/package.json

✅ Files skipped from review due to trivial changes (1)

src/main/javascript/font-awesome-iron-iconset/package.json

🚧 Files skipped from review as they are similar to previous changes (1)

pom.xml

Walkthrough

Bumps project and package versions to 6.0.0, upgrades FontAwesome from 6.6.0 to 7.2.0, and adds a README compatibility entry for Version 6.0.x (FontAwesome 7, vaadin-icon) indicating compatibility with Vaadin 24–25.

Changes

Cohort / File(s)	Summary
Documentation `README.md`	Added `Version 6.0.x` entry to compatibility matrix documenting FontAwesome 7 (uses `vaadin-icon`) and Vaadin 24–25 compatibility.
Build & Package `pom.xml`, `src/main/javascript/font-awesome-iron-iconset/package.json`	Bumped Maven artifact version `5.3.1-SNAPSHOT` → `6.0.0-SNAPSHOT`; updated `fontawesome.version` `6.6.0` → `7.2.0` and `npm.version` `5.2.0` → `6.0.0`; updated npm package `version` to `6.0.0`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Fa 6.6.0 #111: Prior change touching the same build artifacts (pom.xml and package.json) to bump FontAwesome/npm versions.

Suggested reviewers

paodb
mlopezFC

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Upgrade to FontAwesome 7' accurately and clearly describes the main objective of the pull request, which is to upgrade the FontAwesome version from 6.6.0 to 7.2.0 as reflected across all modified files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sonarqubecloud · 2026-04-23T14:08:12Z

Quality Gate failed

Failed conditions
22.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

javier-godoy · 2026-04-23T14:49:07Z

Thanks so much for putting this PR together! This issue was definitely overdue for a fix. I'll aim to get a release by Monday, pending a final internal review.

javier-godoy · 2026-04-23T17:25:13Z

This has been implemented and is available in the latest 6.0.0-SNAPSHOT. You can try it by adding the following repository to your pom.xml:

<repository>
    <id>FlowingCode Snapshots</id>
    <url>https://maven.flowingcode.com/snapshots</url>
    <snapshots>
        <enabled>true</enabled>
    </snapshots>
    <releases>
        <enabled>false</enabled>
    </releases>
</repository>

Sam42R · 2026-04-23T17:58:17Z

Thanks so much for putting this PR together! This issue was definitely overdue for a fix. I'll aim to get a release by Monday, pending a final internal review.

Thanks for finishing PR. Was not sure about the NPM part of the update.

Will test the snapshot release as suggested.

Sam42R · 2026-04-23T18:28:58Z

<repository>
    <id>FlowingCode Snapshots</id>
    <url>https://maven.flowingcode.com/snapshots</url>
    <snapshots>
        <enabled>true</enabled>
    </snapshots>
    <releases>
        <enabled>false</enabled>
    </releases>
</repository>

Tested locally in one of my projects with snapshot version: new iron-icon-font version is working awesome 😉

javier-godoy · 2026-04-28T14:18:01Z

Version 6.0.0 has been released.

Rene R added 2 commits April 22, 2026 20:58

feat: upgrade to font-awesome 7

6f4a825

BREAKING CHANGE (refs FlowingCode#116)

chore: add generated code

6aa1441

Sam42R marked this pull request as ready for review April 22, 2026 19:25

javier-godoy self-requested a review April 23, 2026 11:29

javier-godoy added this to Flowing Code Addons Apr 23, 2026

github-project-automation Bot moved this to To Do in Flowing Code Addons Apr 23, 2026

javier-godoy added 3 commits April 23, 2026 11:03

WIP: upgrade package.json to 6.0.0

25c36b1

WIP: update npm version

d794369

WIP: update npm package

671759c

javier-godoy approved these changes Apr 23, 2026

View reviewed changes

javier-godoy moved this from To Do to In Progress in Flowing Code Addons Apr 23, 2026

javier-godoy merged commit 7c554e1 into FlowingCode:master Apr 23, 2026
3 of 5 checks passed

github-project-automation Bot moved this from In Progress to Pending release in Flowing Code Addons Apr 23, 2026

paodb moved this from Pending release to Done in Flowing Code Addons May 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to FontAwesome 7#125

Upgrade to FontAwesome 7#125
javier-godoy merged 5 commits into
FlowingCode:masterfrom
Sam42R:116-font-awesome-7

Sam42R commented Apr 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Apr 23, 2026

Uh oh!

Uh oh!

javier-godoy commented Apr 23, 2026

Uh oh!

javier-godoy commented Apr 23, 2026

Uh oh!

Sam42R commented Apr 23, 2026

Uh oh!

Sam42R commented Apr 23, 2026

Uh oh!

javier-godoy commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Sam42R commented Apr 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

sonarqubecloud Bot commented Apr 23, 2026

Quality Gate failed

Uh oh!

Uh oh!

javier-godoy commented Apr 23, 2026

Uh oh!

javier-godoy commented Apr 23, 2026

Uh oh!

Sam42R commented Apr 23, 2026

Uh oh!

Sam42R commented Apr 23, 2026

Uh oh!

javier-godoy commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sam42R commented Apr 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 22, 2026 •

edited

Loading