Skip to content

fix: register iconset when vaadin-iconset is defined#106

Merged
paodb merged 5 commits into
masterfrom
fix-20240424
Apr 30, 2024
Merged

fix: register iconset when vaadin-iconset is defined#106
paodb merged 5 commits into
masterfrom
fix-20240424

Conversation

@javier-godoy

Copy link
Copy Markdown
Member

I'm not sure if this is a fix to #105, but certainly it doesn't harm.

+customElements.whenDefined('vaadin-iconset').then(Iconset=>{
Iconset.register('fas', 1000, template);

const iconset = Iconset.getIconset('fas');

for (const name in aliases) {
    iconset._icons[name] = iconset._icons[aliases[name]];
}
+});

@javier-godoy javier-godoy requested review from mlopezFC and paodb April 24, 2024 19:38

@paodb paodb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paodb paodb merged commit 99ad284 into master Apr 30, 2024
@paodb paodb deleted the fix-20240424 branch April 30, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants