Skip to content

Styles: Check marks in the vaadin context menu are hidden locally #24

@anasmi

Description

@anasmi

EDIT: Now that I checked it, you added test scope in the 1.1.0 version. This should fix my issue. Thanks for the amazing add-on! I will leave the bug report, but it's also fine with me to close it.


Describe the bug

Image Crop brings commons-demo dependency that has link to the enhanced-tabs. The enhanced tabs in the enhanced-tabs-legacy.css has

vaadin-context-menu-item::part(checkmark) {
  display: none
}

without theme attribute that ultimately hides all check marks in the application when run locally.

https://github.com/FlowingCode/EnhancedTabs/blob/master/src/main/resources/META-INF/frontend/fcEnhancedTabs/fc-enhanced-tabs-legacy.css#L26

Could you update the styles to add the theme attribute? :)

Expected behavior

Style from the add-on doesn't affect the application itself and encapsulated into the component

Minimal reproducible example

Add a

Add-on Version

1.0.0

Vaadin Version

24.6.0

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions