Skip to content

feat: initial implementation#1

Merged
javier-godoy merged 1 commit into
masterfrom
initial-implementation
Sep 6, 2023
Merged

feat: initial implementation#1
javier-godoy merged 1 commit into
masterfrom
initial-implementation

Conversation

@paodb

@paodb paodb commented Sep 4, 2023

Copy link
Copy Markdown
Member

@javier-godoy & @mlopezFC please review.

@paodb paodb requested a review from mlopezFC September 4, 2023 16:18
@paodb paodb force-pushed the initial-implementation branch from 8b8fdec to 1b1d37a Compare September 4, 2023 17:02
@javier-godoy

javier-godoy commented Sep 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

General

  • The repository is based on Flowing Code add-on starter template.
  • Commit messages follows Flowing Code Commit Message Guidelines
  • Scopes used in commit messages are consistent
  • Code is formatted according to Flowing Code Style Guide

POM

  • <artifactId> has been replaced
  • <inceptionYear> is set to the current year.
  • "Template Add-on" has been replaced in <name> and <description>.
  • <scm> URLs point to this repository.

README

  • The README file clearly describe the purpose of the add-on, highlighting its features and benefits.
  • Links in badges references this add-on.
  • All links in the README are correct and functional.
  • Jenkins badge ends in -addon.
  • All instances of "Template Add-on" have been replaced with the actual full name of the add-on.
  • Double check spelling "add-on" vs "addon"

License

  • License headers are included in all the source files that require a license header.
  • The license header is located before the package declaration.
  • The license header references the name of this project.

Documentation

  • Public classes and methods are well-documented with clear explanations.

Tests

  • Unit and integration tests align with the functionality of the new add-on.

CI

  • Jenkins job is configured for the initial-implementation branch.
  • Webhook has been configured
  • Dependency has been added to AddonsDemo

@paodb paodb force-pushed the initial-implementation branch from 1b1d37a to ab418ca Compare September 4, 2023 17:15
javier-godoy
javier-godoy requested changes Sep 4, 2023
View reviewed changes
Comment thread src/test/java/com/flowingcode/vaadin/addons/badgelist/Person.java Outdated
Comment thread src/main/java/com/flowingcode/vaadin/addons/badgelist/Badge.java
Comment thread src/main/java/com/flowingcode/vaadin/addons/badgelist/BadgeList.java
@paodb paodb force-pushed the initial-implementation branch from ab418ca to 681f250 Compare September 4, 2023 18:04
@paodb paodb requested a review from javier-godoy September 4, 2023 18:04
mlopezFC
mlopezFC requested changes Sep 5, 2023
View reviewed changes

@mlopezFC mlopezFC left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Facing following error when starting via mvn jetty:run

[[1;31mERROR[m] Failed to execute goal [32morg.eclipse.jetty:jetty-maven-plugin:11.0.12:run[m [1m(default-cli)[m on project [36mbadge-list-addon[m: [1;31mUnable to parse configuration of mojo org.eclipse.jetty:jetty-maven-plugin:11.0.12:run for parameter resourceBases: Cannot set 'resourceBases' in class org.eclipse.jetty.maven.plugin.MavenWebAppContext[m: InvocationTargetException: file:///xxxxxxxxxxxxx/BadgeList/src/test/resources/META-INF/resources is not an existing directory. -> [1m[Help 1][m

I think you need to remove line 263 of pom.xml

@paodb paodb force-pushed the initial-implementation branch from 681f250 to 33a8629 Compare September 6, 2023 11:36
@paodb

paodb commented Sep 6, 2023

Copy link
Copy Markdown
Member Author

I think you need to remove line 263 of pom.xml

Done

@javier-godoy javier-godoy merged commit d69552d into master Sep 6, 2023
@javier-godoy javier-godoy deleted the initial-implementation branch September 12, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javier-godoy javier-godoy javier-godoy approved these changes

@mlopezFC mlopezFC mlopezFC approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paodb @javier-godoy @mlopezFC