chore: move vorm-vue from peerDependency to dependency#25
Conversation
- Removes vorm-nuxt from changesets ignore list - Changes vorm-vue from peerDependency to normal dependency in vorm-nuxt - Updates vorm-vue dependency to ^1.1.1 (aligns with current vorm-vue@1.1.0) - Updates vorm-nuxt plugin version to 1.0.2 (upcoming patch release) - Fixes automatic major version bump issue when vorm-vue is patched - Resolves changesets/changesets#1011 - Adds CLAUDE.md for project documentation
🦋 Changeset detectedLatest commit: 364d759 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
vorm/packages/vorm-nuxt/src/module.ts
Lines 30 to 45 in 053367b
The commit message says users can install the module without adding vorm-vue, but the module still auto-imports from 'vorm-vue' in its setup. Nuxt resolves these imports from the application root, so in a project that only installs vorm-nuxt the build will fail with “Cannot resolve package 'vorm-vue'” because the nested dependency inside the module is not picked up. Consumers therefore still need to declare vorm-vue themselves, and the change does not actually fix the problem it targets. Consider keeping a peer dependency or re-exporting the package so the resolver can find it.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
isValid,isDirty,isTouched) inuseVorm#14