Make most of the API @inlinable#43
Merged
Jeehut merged 2 commits intoFlineDev:stablefrom Mar 25, 2020
knothed:work/inlinability
Merged
Make most of the API @inlinable#43Jeehut merged 2 commits intoFlineDev:stablefrom knothed:work/inlinability
@inlinable#43Jeehut merged 2 commits intoFlineDev:stablefrom
knothed:work/inlinability
Conversation
Make relevant methods and property getters `@inlinable` to increase real-time performance. This includes marking required private or internal properties as `@usableFromInline`.
Jeehut
approved these changes
Mar 25, 2020
Member
Jeehut
left a comment
There was a problem hiding this comment.
Looks good, merging. Thank you very much! And sorry for taking so long. 😅
Contributor
Author
|
Haha no Problem. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #40 by marking sensible methods (i.e. any methods where inlining may yield a performance improvement), subscripts and property getters as
@inlinable. This is, in fact, most of the HandySwift API.