Skip to content

Add .DS_Store to .gitignore#8

Merged
Jeehut merged 1 commit intoFlineDev:stablefrom
phoney:feature/gitignore
Aug 15, 2016
Merged

Add .DS_Store to .gitignore#8
Jeehut merged 1 commit intoFlineDev:stablefrom
phoney:feature/gitignore

Conversation

@phoney
Copy link
Copy Markdown
Contributor

@phoney phoney commented Aug 3, 2016

DS_Store files should never be committed and they show up in git status if they aren't gitignored.

@Jeehut
Copy link
Copy Markdown
Member

Jeehut commented Aug 4, 2016

While it is true that ignoring .DS_STORE files via gitignores is important I find this specific approach inconsistent. The DS_STORE file is a OS specific file (not a project specific one) and should therefore be ignored via gloabal gitignores by all developers using a Mac.

We could of course provide an additional layer and ignore OS specific files in project level, too (since iOS development is mainly done on a Mac), but in that case we should cover all OS specific files. For example we could include all not already added file paths from OS X and Xcode files in the gitignore project on GitHub.

I'm usually not a fan of this approach when working with my colleagues, but maybe for open source projects this is necessary. What do you think?

@phoney
Copy link
Copy Markdown
Contributor Author

phoney commented Aug 4, 2016

This is the .gitignore file I usually use http://stackoverflow.com/questions/49478/git-ignore-file-for-xcode-projects. I did intend to have it setup as my global .gitignore but I just realized that I need to use git config to set it as the global .gitignore and didn't have it set. That's the reason I was seeing the .DS_Store files in my git status results.

I can't think of any reason that someone would want to commit DS_Store files or have them interact with git in any way. I don't think there are any other kind of OS X files that might find their way into a git workspace.

I do always have .DS_Store in my .gitignore files, both local and the global one but I understand your reasoning that the global .gitignore should have this covered. So I think it should be in the local .gitignore but I can live without it if you really prefer it not be there.

@Jeehut
Copy link
Copy Markdown
Member

Jeehut commented Aug 15, 2016

No worries, as I stated earlier I find it good that it is present for public projects. I just wanted to make sure we also cover other files if there are any. But DS_Store seems to be good for now. Merging it.

@Jeehut Jeehut merged commit 3e711fc into FlineDev:stable Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants