[Feature]: Layout and App Bar Improvements#53
Merged
kristenmills merged 5 commits intodevelopfrom Dec 16, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #53 +/- ##
===========================================
+ Coverage 62.21% 63.05% +0.83%
===========================================
Files 105 106 +1
Lines 1506 1551 +45
Branches 212 223 +11
===========================================
+ Hits 937 978 +41
- Misses 568 572 +4
Partials 1 1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Refactors the Layout to use css grid to make it easier to maintain long term. Also adds support for injecting components into the nav which will be utilized for plugins that currently use Secondary Nav.
Detailed changes:
Addressed issues: