Skip to content

Pending List Pt 2. #44

Merged
kristenmills merged 26 commits intodevelopfrom
pending-list-pt2
Dec 12, 2019
Merged

Pending List Pt 2. #44
kristenmills merged 26 commits intodevelopfrom
pending-list-pt2

Conversation

@kristenmills
Copy link
Copy Markdown
Member

@kristenmills kristenmills commented Dec 7, 2019 •
edited
Loading

Motivation for changes:

Pending list was kind of in a wip state, this get's it looking kind of nice and mostly functional.

Detailed changes:

  • Move everything to use hooks and typescript
  • Add entry, Add List, and Remove list functionality.
  • Build new Entry utilities to replace FlexGetEntry
  • Build out some reusable cards for entries
  • Improved test coverage
  • A few Random unrelated things:
    • dependency upgrades
    • Fix the version components
    • use material icons instead of font awesome (don't think that dependency is fully cleaned up but almost is)

Addressed issues:

To Do:

  • Add List
  • View Lists
  • View List Entries
  • Approve/Reject Entry
  • Remove/Inject Entry
  • Remove List
  • Add Entry
  • Fix FlexgetEntry
  • New Pagination (might replace with Infinite scroll later)
  • tests
  • Rebuild Entry cards
    • Default
    • Series
    • Movies
    • Episodes

@kristenmills kristenmills mentioned this pull request Dec 8, 2019
Closed
14 tasks
@kristenmills kristenmills changed the title Pending List Pending List Pt 2. Dec 11, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2019 •
edited
Loading

Codecov Report

Merging #44 into develop will increase coverage by 8.13%.
The diff coverage is 37.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #44      +/-   ##
===========================================
+ Coverage    52.78%   60.91%   +8.13%     
===========================================
  Files          120      115       -5     
  Lines         1544     1502      -42     
  Branches       185      200      +15     
===========================================
+ Hits           815      915     +100     
+ Misses         718      586     -132     
+ Partials        11        1      -10
Impacted Files Coverage Δ
src/common/TextField/old.jsx 100% <ø> (ø)
src/common/SecondaryNav/styles.ts 100% <ø> (ø)
src/core/history.ts 0% <ø> (ø)
src/core/home/Home/index.tsx 100% <ø> (ø)
src/plugins/pendingList/EntryCard/index.tsx 0% <0%> (ø)
...rc/plugins/pendingList/InjectEntryDialog/index.tsx 0% <0%> (ø)
src/common/TextField/Select.tsx 0% <0%> (ø)
src/common/SelectField/index.tsx 0% <0%> (ø)
src/utils/hooks/actions.ts 0% <0%> (ø)
src/plugins/pendingList/AddListDialog/index.tsx 0% <0%> (ø)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917ca6a...cd1b0cb. Read the comment docs.

@kristenmills kristenmills marked this pull request as ready for review December 12, 2019 06:07
@kristenmills kristenmills merged commit 6da1334 into develop Dec 12, 2019
@kristenmills kristenmills deleted the pending-list-pt2 branch December 12, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kristenmills