Skip to content

webui form data edited from 'label' to 'category'#984

Closed
barhom wants to merge 1 commit intoFlexget:developfrom
barhom:qbittorrent-download-plugin-fix-label
Closed

webui form data edited from 'label' to 'category'#984
barhom wants to merge 1 commit intoFlexget:developfrom
barhom:qbittorrent-download-plugin-fix-label

Conversation

@barhom
Copy link
Copy Markdown

@barhom barhom commented Mar 28, 2016

The qbittorrent-nox webui takes 'category' and not 'label' as its formdata to specify which label to add the torrent to

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling df9b598 on barhom:qbittorrent-download-plugin-fix-label into 9c895f2 on Flexget:develop.

@dsemi
Copy link
Copy Markdown
Contributor

dsemi commented Mar 28, 2016

I just tested, 'label' is working fine for me as-is. What version of qBittorrent are you using? I'm on v3.3.3 and my Web UI says 'Labels' not 'Categories' (I'm also not using qbittorrent-nox). Changing label to category breaks labeling for me. I'd try updating your version of qBittorrent to see if that fixes your issue, and if not then a better solution would be to add a new config option and specify on the wiki how it differs from label.

@barhom
Copy link
Copy Markdown
Author

barhom commented Mar 28, 2016

Im using latest master branch of qbittorrent (3.4 something Alpha). Are you sure your WEBUI shows 'labels' and not 'categories'?

Here's an image from the WebUI:
http://i.imgur.com/bCBAABb.png

@dsemi
Copy link
Copy Markdown
Contributor

dsemi commented Mar 28, 2016

Looks like they changed the name in this commit. The most recent release is still v3.3.3 and that uses Labels.
In my opinion, qBittorrent shouldn't be changing names in their API because it'll break everything that used 'label' when they release v3.4.0. You can open an issue with them to change the name back or support either label or category. The other option is to check for a version number in the flexget output plugin and change the key to either 'label' or 'category' based on whether the version is above 3.4.0 or not.
Is there something in the master branch that you need that's not in v3.3.3. If not then you can just use that version and the plugin will work properly.

@barhom
Copy link
Copy Markdown
Author

barhom commented Mar 28, 2016

@dsemi
I edited the PR a little bit. This way we send both label and category to support both old and new version.
I doubt this will introduce any errors, what do you think?

@landscape-bot
Copy link
Copy Markdown

Code Health
Repository health decreased by 0.18% when pulling 326a0e8 on barhom:qbittorrent-download-plugin-fix-label into 9c895f2 on Flexget:develop.

@landscape-bot
Copy link
Copy Markdown

Code Health
Repository health decreased by 0.01% when pulling 9c397db on barhom:qbittorrent-download-plugin-fix-label into 9c895f2 on Flexget:develop.

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling f7a4b91 on barhom:qbittorrent-download-plugin-fix-label into 9c895f2 on Flexget:develop.

The qbittorrent-nox webui takes 'category' and not 'label' as its formdata to specify which label to add the torrent to since v3.4.
We have retained compatability with v3.3.3 and older with keeping the 'label' form data as well.
@barhom barhom force-pushed the qbittorrent-download-plugin-fix-label branch from f7a4b91 to d91e1c5 Compare March 28, 2016 19:38
@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling d91e1c5 on barhom:qbittorrent-download-plugin-fix-label into 9c895f2 on Flexget:develop.

@dsemi
Copy link
Copy Markdown
Contributor

dsemi commented Mar 29, 2016

Seems fine to me as long as no versions break with the extra parameters.

@liiight
Copy link
Copy Markdown
Member

liiight commented Mar 29, 2016

can you sync the pr please?

@stevezau
Copy link
Copy Markdown
Contributor

update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants