Skip to content

next_series_episodes: Put a limit on number of episodes to backfill#4244

Merged
gazpachoking merged 5 commits intodevelopfrom
max_backfill
Feb 22, 2025
Merged

next_series_episodes: Put a limit on number of episodes to backfill#4244
gazpachoking merged 5 commits intodevelopfrom
max_backfill

Conversation

@gazpachoking
Copy link
Copy Markdown
Member

@gazpachoking gazpachoking commented Feb 12, 2025

Motivation for changes:

If there are a very large number of episodes to backfill for a given season it is probably a parsing error. Log a warning rather than searching for more than 25 episodes (by default).

Also adds an option backfill_limit for the user to override how big of an episode gap will be tried to backfill.

Addressed issues/feature requests:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 12, 2025

Test Results

 15 files  ±0   15 suites  ±0   3m 16s ⏱️ +3s
 49 tests ±0   47 ✅ ±0   2 💤 ±0  0 ❌ ±0 
735 runs  ±0  695 ✅ ±0  40 💤 ±0  0 ❌ ±0 

Results for commit f9c8668. ± Comparison against base commit be3c243.

♻️ This comment has been updated with latest results.

@BrutuZ
Copy link
Copy Markdown
Contributor

BrutuZ commented Feb 12, 2025

I guess we could put a max on the number of 'missing' eps? But would it be hard coded or configurable? Should it prevent any searching at all due to thinking it's an error, or just limit it to the cap?

Configurable with a default of 25 (an average 2-cour TV season + 1) would be my vote

@gazpachoking
Copy link
Copy Markdown
Member Author

backfill_cap, do we like that as the option name?

@BrutuZ
Copy link
Copy Markdown
Contributor

BrutuZ commented Feb 21, 2025

While it is more descriptive, maybe limit would be more consistent?

@gazpachoking gazpachoking changed the title next_series_episodes: Put a cap on number of episodes to backfill next_series_episodes: Put a limit on number of episodes to backfill Feb 22, 2025
@gazpachoking gazpachoking merged commit f5434da into develop Feb 22, 2025
21 checks passed
@gazpachoking gazpachoking deleted the max_backfill branch February 22, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Series title parsing failure causes huge amount of discover queries

2 participants