Skip to content

Update seen CLI for consistency#3814

Merged
gazpachoking merged 4 commits intodevelopfrom
seen_cli_tasks
Aug 17, 2023
Merged

Update seen CLI for consistency#3814
gazpachoking merged 4 commits intodevelopfrom
seen_cli_tasks

Conversation

@gazpachoking
Copy link
Copy Markdown
Member

Motivation for changes:

Clean up some ambiguity and problems with seen CLI

Detailed changes:

  • --tasks could take multiple arguments, which meant the positional value parameter could be consumed by this if it was placed before the value. It has been replaced by --task which only takes one task name, but can be specified multiple times.
    old: seen forget valuetoforget --tasks taska taskb new: seen forget --task taska --task taskb valuetoforget
  • The value before could be a task name which would delete all the seen entries for that task. I didn't like the ambiguity of this, so you now must specify the task name with the --task parameter, along with a wildcard for the value.
    old: seen forget sometaskname new: seen forget --task sometaskname *
  • Allows multiple tasks to be specified for seen add (only one could be done at a time before)
  • Also fixes a crash if there were things that looked like rich markup in entry titles for seen search

Addressed issues/feature requests:

CLI Usage

# Add a seen value to 2 tasks
flexget seen add --task task1 --task task2 "the seen thing"
# Forget everything from one task
flexget seen forget --task task1 *
# Forget everything from tasks matching a glob
flexget seen forget --task movie-* *

To Do:

  • Bump version to indicate breaking change
  • Write upgradeactions

@gazpachoking gazpachoking merged commit 80fe9f1 into develop Aug 17, 2023
@gazpachoking gazpachoking deleted the seen_cli_tasks branch August 30, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seen forget --tasks behaviour

1 participant