Skip to content

Cross build docker images for more arch#3743

Merged
gazpachoking merged 5 commits intoFlexget:developfrom
maxcanna:patch-1
May 3, 2023
Merged

Cross build docker images for more arch#3743
gazpachoking merged 5 commits intoFlexget:developfrom
maxcanna:patch-1

Conversation

@maxcanna
Copy link
Copy Markdown
Contributor

Motivation for changes:

Detailed changes:

Addressed issues/feature requests:

  • Fixes # .

Config usage if relevant (new plugin or updated schema):

paste_config_here

Log and/or tests output (preferably both):

paste output here

To Do:

  • Stuff..

@trim21
Copy link
Copy Markdown
Contributor

trim21 commented Apr 26, 2023

it failed in these lines:

Flexget/Dockerfile

Lines 17 to 18 in bf0fd6d

RUN pip install -U pip && \
pip install -r /flexget/dev-requirements.txt

You will need a cross arch way to bundle webui, maybe just move previous wget step to base docker instead of using dev_tools.py

https://github.com/Flexget/Flexget/pull/3739/files

@maxcanna
Copy link
Copy Markdown
Contributor Author

@trim21 It's working now. Perhaps I'm too naive here but wouldn't something like this:

https://github.com/maxcanna/dockerfiles/blob/master/flexget/Dockerfile

suffice?

@maxcanna
Copy link
Copy Markdown
Contributor Author

maxcanna commented May 3, 2023

@trim21 any updates on this? I saw #3748 but perhaps we can go with this in the meantime. Wdyt?

@trim21
Copy link
Copy Markdown
Contributor

trim21 commented May 3, 2023

I don't have write permission, you need to ask @gazpachoking

@gazpachoking
Copy link
Copy Markdown
Member

Seems good to me. We could probably split our dev requirements group into dev and release (to eliminate the ruff install, and the need for cargo here) but that could come in a separate PR. LGTM, thanks!

@gazpachoking gazpachoking merged commit a851291 into Flexget:develop May 3, 2023
@maxcanna maxcanna deleted the patch-1 branch May 3, 2023 14:16
@gazpachoking
Copy link
Copy Markdown
Member

@maxcanna Which platforms were you actually needing? I pulled some out that were harder to support due to lack of prebuilt wheels on pypi. Left arm64 in there other than the default amd64.

@maxcanna
Copy link
Copy Markdown
Contributor Author

@gazpachoking I need linux/arm/v7 in order to be able to run it on raspberry PI on 32 bit OS. Thank you for taking this into account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants