Skip to content

Fix for empty lazy field#3689

Merged
gazpachoking merged 2 commits intoFlexget:developfrom
StefftheEmperor2:fix_for_empty_lazy_field
Feb 12, 2023
Merged

Fix for empty lazy field#3689
gazpachoking merged 2 commits intoFlexget:developfrom
StefftheEmperor2:fix_for_empty_lazy_field

Conversation

@StefftheEmperor2
Copy link
Copy Markdown
Contributor

@StefftheEmperor2 StefftheEmperor2 commented Feb 12, 2023

Motivation for changes:

make_rss throws error when evaluating links for entries where lookup fails

Detailed changes:

  • Not only check for existance of a field, but also check, whether it's filled

Log and/or tests output (preferably both):

  File "/home/stefan/arbeit/privat/flexget/flexget/plugins/output/rss.py", line 258, in on_task_exit
    hasher.update(db_item.link.encode('utf8'))
    │      │      │       └ <sqlalchemy.orm.attributes.InstrumentedAttribute object at 0x7f0083be8ef0>
    │      │      └ <flexget.plugins.output.rss.RSSEntry object at 0x7f008144b950>
    │      └ <method 'update' of '_hashlib.HASH' objects>
    └ <sha1 _hashlib.HASH object @ 0x7f0082650a90>

after:

2023-02-12 22:30:49 TRACE    make_rss      offer_series    Adding Top Gun into rss flexget.rss
2023-02-12 22:30:49 VERBOSE  make_rss      offer_series    Writing output rss to flexget.rss

gazpachoking
gazpachoking reviewed Feb 12, 2023
View reviewed changes
@StefftheEmperor2 @gazpachoking
use better way for cheking for existance of a field
4cfe615 
Co-authored-by: Chase Sterling <chase.sterling@gmail.com>
@gazpachoking
Copy link
Copy Markdown
Member

gazpachoking commented Feb 12, 2023

Looks good to me!

@gazpachoking gazpachoking merged commit fb27382 into Flexget:develop Feb 12, 2023
@gazpachoking
Copy link
Copy Markdown
Member

gazpachoking commented Feb 12, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gazpachoking gazpachoking gazpachoking left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StefftheEmperor2 @gazpachoking