Add suite of test cases to the sftp_{list, download, upload} plugins.#3641
Merged
paranoidi merged 5 commits intoFlexget:developfrom Dec 25, 2022
kingamajick:add_sftp_tests
Merged
Add suite of test cases to the sftp_{list, download, upload} plugins.#3641paranoidi merged 5 commits intoFlexget:developfrom kingamajick:add_sftp_tests
paranoidi merged 5 commits intoFlexget:developfrom
kingamajick:add_sftp_tests
Conversation
This change uses a local test sftp server to assert the behaviour of the various sftp plugins. By using an actually test server it opens the door to moving to Paramiko if needed (see #3619) while ensuring that the current functionality doesn't break. Note: In addition it also enables a host hey to be specified via the plugin config for the list and upload plugins. This makes it possible to use the test sftp server without adding an entry to known_hosts.
for more information, see https://pre-commit.ci
The previous change set corrected the key from ssh_key -> host_key which caused the schema validation to work correctly uncovering some errors in its configuration.
Convert dict.keys -> list
Member
|
Excellent, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Test suite missing for sftp plugins
Detailed changes:
This change uses a local test sftp server to assert the behaviour of the various sftp plugins. By using an actually test server it opens the door to moving to Paramiko if needed (see #3619) while ensuring that the current functionality doesn't break.
Note: In addition it also enables a host hey to be specified via the plugin config for the list and upload plugins. This makes it possible to use the test sftp server without adding an entry to known_hosts.
Addressed issues/feature requests:
First step towards fixing #3619
Config usage if relevant (new plugin or updated schema):
Following config added for list and upload plugins.