[add] plex_watchlist: Add a new list plugin to access plex watchlist #3632
[add] plex_watchlist: Add a new list plugin to access plex watchlist #3632gazpachoking merged 16 commits intoFlexget:developfrom lostb1t:plex_watchlist
Conversation
|
@gazpachoking i think that's everything. Let me know your thoughts. |
|
Looks great to me! One thing I'm not sure is if we should add the new dep directly to our requirements, or make it an optional dep and give user a warning that it needs to be installed if it isn't. Leaning toward the latter. |
as a user, i would be annoyed if i have to install additional dependencies. It's not a big dependency in size and installation time, so i would chose the more user friendly approach and have it already included |
I'm for optional dependency too. There are enough of those already to not be a strange procedure to install them. |
|
K I'll remove the dependency tomorrow. |
I agree it isn't awesome, but we have quite a few plugins that all have deps specific to only that one plugin, and our dep list could get quite large with things that a majority of people wouldn't be using. I've been considering a more formal interface for these sorts of optional dependencies, which would allow installing them with a special command, like |
|
Here's an example of how we do it Flexget/flexget/plugins/operate/cfscraper.py Lines 24 to 30 in 97ca6d2 Usually in on_task_start, so it fails early |
|
Dep can be added here to make sure the test suite installs it Lines 109 to 112 in 724ecfb |
|
Removed the dependency. |
for more information, see https://pre-commit.ci
|
Awesome! Looks good, thank you! |
|
Please add documentation here, https://flexget.com/en/Plugins/List/plex_watchlist I linked it in relevant places |
see #3488 for info
Also added some basic tests
When adding an entry to the watchlist with no guid it will search plex discover and match on supported ids (imdb_id etc) or title.
But maybe this needs to be in a separate lookup plugin:
plex_discover_lookupor something.