Skip to content

Update docker.io/python Docker tag to v3.11#3595

Closed
renovate[bot] wants to merge 2 commits intodevelopfrom
renovate/docker.io-python-3.x
Closed

Update docker.io/python Docker tag to v3.11#3595
renovate[bot] wants to merge 2 commits intodevelopfrom
renovate/docker.io-python-3.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Nov 3, 2022

Mend Renovate

This PR contains the following updates:

Package Type Update Change
docker.io/python final minor 3.10-alpine -> 3.11-alpine
docker.io/python stage minor 3.10-alpine -> 3.11-alpine

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/docker.io-python-3.x branch from 4a9bd5b to f2ab66e Compare January 17, 2023 22:18
@renovate renovate bot force-pushed the renovate/docker.io-python-3.x branch from f2ab66e to 19dd55c Compare March 17, 2023 16:02
@gazpachoking
Copy link
Copy Markdown
Member

This seems like a good plan, any potential issues?

@trim21
Copy link
Copy Markdown
Contributor

trim21 commented Apr 10, 2023

This seems like a good plan, any potential issues?

Yes

COPY --from=0 /flexget-ui-v2 /usr/local/lib/python3.10/site-packages/flexget/ui/v2/

This happened before when we upgrade docker python version from 3.9 to 3.10

trim21

This comment was marked as duplicate.

Copy link
Copy Markdown
Contributor

@trim21 trim21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to upgrade python site package path for webui installation

@gazpachoking
Copy link
Copy Markdown
Member

need to upgrade python site package path for webui installation

Ahh indeed. Good catch.

@renovate
Copy link
Copy Markdown
Contributor Author

renovate bot commented Apr 10, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

rm -rf /wheels

COPY --from=0 /flexget-ui-v2 /usr/local/lib/python3.10/site-packages/flexget/ui/v2/
COPY --from=0 /flexget-ui-v2 /usr/local/lib/python3.11/site-packages/flexget/ui/v2/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should move this line right after FROM so next time we'll notice it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or add a warning comment about it before FROM

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can switch it to call the dev_tools.py bundle-webui command like the release script does rather than doing the copy manually. That would mean we don't have to remember anymore.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe create a TODO issue and do it later😁

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to give that method a test and opened up a separate PR that more accurately describes the change. Will leave that one open for a minute in case anyone notices issues with that implementation.

@gazpachoking gazpachoking deleted the renovate/docker.io-python-3.x branch August 18, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants