Skip to content

Replace obsoleted and unmaintaned transmissionrpc#2791

Merged
gazpachoking merged 1 commit intoFlexget:developfrom
rsekman:replace_transmissionrpc
Dec 25, 2020
Merged

Replace obsoleted and unmaintaned transmissionrpc#2791
gazpachoking merged 1 commit intoFlexget:developfrom
rsekman:replace_transmissionrpc

Conversation

@rsekman
Copy link
Copy Markdown
Contributor

@rsekman rsekman commented Dec 25, 2020

Motivation for changes:

transmissionrpc is unmaintained. Swap to transmission-rpc as suggested in #2727.

Detailed changes:

Drop-in replacement of imports.
The newer transmission-rpc does not provide HTTPHandlerError. Instead it raises exceptions from requests.exceptions. Error handling on connecting to transmission has to be changed accordingly.

Addressed issues:

Possible improvements

Error handling could be more fine-grained, but requests.exceptions are very detailed as they are.

@gazpachoking
Copy link
Copy Markdown
Member

gazpachoking commented Dec 25, 2020

Excellent, looks good to me. Thanks!

@gazpachoking gazpachoking merged commit ed454bc into Flexget:develop Dec 25, 2020
@antonfischl1980 antonfischl1980 mentioned this pull request Dec 28, 2020
Closed
@ksurl
Copy link
Copy Markdown
Contributor

ksurl commented Dec 29, 2020 •
edited
Loading

From_transmission is not working. See error #2794.

@mfonville
Copy link
Copy Markdown
Contributor

mfonville commented Jan 3, 2021 •
edited
Loading

The pip dependencies have not been updated to reflect this change. Users miss the transmission-rpc library and get an error:
CRITICAL transmission xxx transmission-rpc module version 0.11 or higher required.

(and at least in the Ubuntu repositories, only the old transmissionrpc python3 package is offered, and not this fork)

@BrutuZ
Copy link
Copy Markdown
Contributor

BrutuZ commented Jan 3, 2021

transmission-rpc is an optional dependency like many others. Flexget warns it's required when you call a plugin that needs it, the rest is up to you

@mfonville
Copy link
Copy Markdown
Contributor

mfonville commented Jan 3, 2021

True that the dependency is optional. So I was wrong to mention it as a pip-dependency.
But users get now when upgrading their Flexget no explicit notice that this dependency has changed. And when executing Flexget and receiving that critical error, I have doubts whether they notice the extra dash in transmission-rpc and understand that it is different from the package they have installed in the past.

Maybe an explicit error if transmissionrpc has been found but no transmission-rpc could help them.

@ksurl
Copy link
Copy Markdown
Contributor

ksurl commented Jan 3, 2021

I've added it to the Upgrade Actions page

@X-dark X-dark mentioned this pull request Jan 4, 2021
Closed
@Karlson2k
Copy link
Copy Markdown
Contributor

Karlson2k commented Jan 8, 2021

@gazpachoking, could you please look into related issue #2794?

@X-dark X-dark mentioned this pull request Jan 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rsekman @gazpachoking @ksurl @mfonville @BrutuZ @Karlson2k