[fix] anilist: Exception if field is not set on the site#2710
Merged
gazpachoking merged 6 commits intoFlexget:developfrom Oct 16, 2020
Merged
[fix] anilist: Exception if field is not set on the site#2710gazpachoking merged 6 commits intoFlexget:developfrom
anilist: Exception if field is not set on the site#2710gazpachoking merged 6 commits intoFlexget:developfrom
Conversation
Alphabetize Entry() fields to make code more readable
liiight
reviewed
Jul 23, 2020
liiight
approved these changes
Jul 23, 2020
Member
liiight
left a comment
There was a problem hiding this comment.
that build failure seems unrelated, looking into it
ianstalk
reviewed
Jul 23, 2020
ianstalk
reviewed
Jul 23, 2020
Contributor
Author
|
Empty strings caused an exception when performing case operations, the reason I had the string conversions in place.
Sent from my Samsung Galaxy smartphone.
|
Contributor
|
Then check if it has a value before manipulating it.
…On Thu, Jul 23, 2020, 7:40 PM BrutuZ ***@***.***> wrote:
Empty strings caused an exception when performing case operations, the
reason I had the string conversions in place.
Sent from my Samsung Galaxy smartphone.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2710 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABLLRB4DXSA4LZAXKENHATR5DC5TANCNFSM4PE23KNA>
.
|
Contributor
Author
|
Testing for empty value now |
ianstalk
approved these changes
Jul 25, 2020
Contributor
Author
|
Bump. I'm stuck at this 3.1.68 branch since a couple of entries in my list have empty values that aren't handled without this, hence crashing the task. |
Contributor
Author
|
Paging @Flexget |
Member
|
Seems good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Discovered that site entries could have empty fields, usually ones added from very early announcements or teasers. That would result in exceptions due to parsing errors since some fields were taken for granted.
Detailed changes:
dict().get()NoneTypeexceptionsal_linksoutput:[{'site': '*site_name*', 'url': '*site_url*'}, ... ]{'*site_name*': '*site_url*', ... }Entry()fields to improve code readability