Fix trakt lazy lookup serialization#2596
Merged
gazpachoking merged 3 commits intodevelopfrom Feb 11, 2020
Merged
Conversation
paranoidi
reviewed
Feb 5, 2020
| return entry | ||
|
|
||
|
|
||
| def add_lazy_fields(entry: entry.Entry, lazy_lookup_name, media_type): |
Member
There was a problem hiding this comment.
should we use type hinting for all new / modified code?
Member
Author
There was a problem hiding this comment.
Yeah, I think it's a pretty good idea. Definitely for functions that might be called from outside the module.
paranoidi
reviewed
Feb 5, 2020
| trakt_ep_id | ||
| trakt_ep_tvdb_id | ||
|
|
||
| def get_db_data_for(data_type, entry, session): |
Member
Author
There was a problem hiding this comment.
Hmm. Not sure. Don't think db.py deals with entries at all right now. This is function is sortof about translating the entry into the db calls in db.py
cvium
reviewed
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
This is to fix #2583. Trakt lazy lookups could not be serialized, because they were passing functions in the parameters to the lazy lookups.
This plugin was sorta confusing, I maybe made it slightly better than it was, but there is still room for improvement.