Skip to content

Replace folder.walk with folder.rglob#2495

Merged
liiight merged 1 commit intoFlexget:developfrom
carno:exists-pathlib
Nov 14, 2019
Merged

Replace folder.walk with folder.rglob#2495
liiight merged 1 commit intoFlexget:developfrom
carno:exists-pathlib

Conversation

@carno
Copy link
Copy Markdown
Contributor

@carno carno commented Nov 13, 2019

Motivation for changes:

Bug fix

Detailed changes:

  • adjust directory iteration to pathlib in exists plugin

Addressed issues:

Implemented feature requests:

  • Feathub #XX.

Config usage if relevant (new plugin or updated schema):

N/A

Log and/or tests output (preferably both):

N/A

To Do:

  • N/A

@carno
Copy link
Copy Markdown
Contributor Author

carno commented Nov 13, 2019

I'm not sure if this is the best approach, but it seems to work similarly to the previous path.py based solution(at least, at first glance) and allowed me to download my evening series ;-)

@liiight liiight merged commit 1b6997c into Flexget:develop Nov 14, 2019
@liiight
Copy link
Copy Markdown
Member

liiight commented Nov 14, 2019

LGTM. Thanks!

@carno carno deleted the exists-pathlib branch November 14, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled error in plugin exists: 'PosixPath' object has no attribute 'walk'

2 participants