Skip to content

GuessIt Parser -- Initialize a MatchesDict()#2318

Merged
gazpachoking merged 2 commits intoFlexget:developfrom
XVicarious:guessit_check_dict
Feb 7, 2019
Merged

GuessIt Parser -- Initialize a MatchesDict()#2318
gazpachoking merged 2 commits intoFlexget:developfrom
XVicarious:guessit_check_dict

Conversation

@XVicarious
Copy link
Copy Markdown
Contributor

Motivation for changes:

I didn't read and the previous pull only fixed the first level of issues.

Detailed changes:

  • Instead of checking if its a special kind of dictionary, initialize as a MatchesDict and it works like magic. Passes the tests too.

@gazpachoking
Copy link
Copy Markdown
Member

I think this is good now, we just need to resolve the conflicts before merging.

Brian Maurer and others added 2 commits February 6, 2019 18:53
@gazpachoking gazpachoking merged commit 4b372a2 into Flexget:develop Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants