PassThePopcorn ignore movie year discrepancies if we have imdb id#2241
Merged
cvium merged 2 commits intoFlexget:developfrom Oct 25, 2018
jtpavlock:ptp-ignore-year
Merged
PassThePopcorn ignore movie year discrepancies if we have imdb id#2241cvium merged 2 commits intoFlexget:developfrom jtpavlock:ptp-ignore-year
cvium merged 2 commits intoFlexget:developfrom
jtpavlock:ptp-ignore-year
Conversation
paranoidi
reviewed
Oct 24, 2018
| # skip movies with wrong year | ||
| # don't consider if we have imdb_id (account for year discrepancies if we know we have | ||
| # the right movie) | ||
| if (not entry.get('imdb_id') and entry.get('movie_year') and |
Member
There was a problem hiding this comment.
More pythonic way to check if field is set:
'movie_year' in entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Sometimes if there is a year discrepancy in a movie's release year between trakt (or other input sites that originally set movie_year), imdb, and passthepopcorn, it will reject the movie on passthepopcorn based on this discrepancy. This change will allow to ignore year discrepancies if we are dealing specifically with an imdb_id (no possibility of mismatches).
Detailed changes:
Note that if whatever plugin produces the imdb_id produces the wrong or incorrect id, PassThePopcorn will download that movie with the imdb_id without failsafe procedure.