Skip to content

Remove GPLed code from rtorrent implementation#2235

Merged
gazpachoking merged 3 commits intodevelopfrom
rtorrent_sgci
Nov 7, 2018
Merged

Remove GPLed code from rtorrent implementation#2235
gazpachoking merged 3 commits intodevelopfrom
rtorrent_sgci

Conversation

@gazpachoking
Copy link
Copy Markdown
Member

@gazpachoking gazpachoking commented Oct 20, 2018

Motivation for changes:

SGCITransport implementation was GPLed code. See #2196 This is hopefully just to inspire somebody to finish this job, as I haven't installed rtorrent or tested anything. Somebody with rtorrent can use this as a jumping off point for testing.

Addressed issues:

To Do:

  • Actually test it, probably fix some stuff.

@paranoidi
Copy link
Copy Markdown
Member

paranoidi commented Oct 21, 2018 •
edited
Loading

Unfortunately does not work.

BUG: Unhandled error in plugin rtorrent: unsupported XML-RPC protocol
Traceback (most recent call last):
  File "/home/paranoidi/apps/flexget/flexget/task.py", line 486, in __run_plugin
    return method(*args, **kwargs)
  File "/home/paranoidi/apps/flexget/flexget/event.py", line 23, in __call__
    return self.func(*args, **kwargs)
  File "/home/paranoidi/apps/flexget/flexget/plugins/clients/rtorrent.py", line 445, in on_task_output
    session=task.requests)
  File "/home/paranoidi/apps/flexget/flexget/plugins/clients/rtorrent.py", line 223, in __init__
    self._server = sp(self.uri)
  File "/home/paranoidi/apps/flexget/flexget/plugins/clients/rtorrent.py", line 164, in create_proxy
    return xmlrpc_client.ServerProxy(url)
  File "/usr/lib/python3.5/xmlrpc/client.py", line 1398, in __init__
    raise OSError("unsupported XML-RPC protocol")
OSError: unsupported XML-RPC protocol

Value of url

/home/paranoidi/torrents/.socket/rpc.socket

Plugin configuration is using socket, where this comes from ...

rtorrent:
  uri: ~/torrents/.socket/rpc.socket
  .
  .

@gazpachoking
Copy link
Copy Markdown
Member Author

gazpachoking commented Oct 22, 2018

@paranoidi I may have fixed that issue

@paranoidi
Copy link
Copy Markdown
Member

paranoidi commented Nov 1, 2018

Re-testing

@gazpachoking gazpachoking merged commit a77d3f1 into develop Nov 7, 2018
@gazpachoking
Copy link
Copy Markdown
Member Author

gazpachoking commented Nov 7, 2018

@paranoidi confirmed this working, open up another ticket if someone finds more issues.

Thanks @JohnDoee

@gazpachoking gazpachoking deleted the rtorrent_sgci branch January 28, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rtorrent SCGI transport looks like GPLed code with its license stripped

2 participants

@gazpachoking @paranoidi