Add more entry fields to PassThePopcorn search plugin#2231
Merged
cvium merged 5 commits intoFlexget:developfrom Oct 20, 2018
jtpavlock:develop
Merged
Add more entry fields to PassThePopcorn search plugin#2231cvium merged 5 commits intoFlexget:developfrom jtpavlock:develop
cvium merged 5 commits intoFlexget:developfrom
jtpavlock:develop
Conversation
cvium
reviewed
Oct 20, 2018
| e['ptp_resolution'] = torrent['Resolution'] # 1080p, 720p, etc. | ||
| e['ptp_source'] = torrent['Source'] # blu-ray, dvd, etc. | ||
| e['ptp_container'] = torrent['Container'] # mkv, vob ifo, etc. | ||
| e['ptp_codec'] = torrent['Codec'] # x264, XviD, etc. |
Contributor
There was a problem hiding this comment.
Can we be certain that all these keys will exist in every response?
Contributor
Author
There was a problem hiding this comment.
Actually, the only one we need to worry about is remastertitle which I missed the first time around. The rest are all required and will always be there. Regardless, I switched the key access to use dict.get() which should prevent any issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Ability for more reliable and finer control over passthepopcorn search results.
Detailed changes:
To Do: