Merged
Conversation
…arameters Without the capitalization it is broken
cvium
reviewed
Jul 13, 2018
| except RequestException as e: | ||
| log.error('Request error: %s' % str(e)) | ||
| return series_info | ||
| return # if it failed, return empty |
Contributor
There was a problem hiding this comment.
You could just initialize series_info to None at the top of the function
Contributor
Author
There was a problem hiding this comment.
yes, that was also an option I considered, I will change it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NPO updated their website, to make the plugin work again we need this change.
Also fixed an error that could occur if
_get_series_infofailed to fetch info