NPOStart gives regularly 502 errors, handle those#2163
NPOStart gives regularly 502 errors, handle those#2163cvium merged 3 commits intoFlexget:developfrom
Conversation
increase the domain delay limit do not raise a plugin-error on non-critical failed fetches
| 'tiletype': 'asset'} | ||
|
|
||
| if not series_info: | ||
| while not series_info: # loop, so that if it fails it will retry |
There was a problem hiding this comment.
This is potentially an endless loop...
There was a problem hiding this comment.
I will update the PR, instead of an endless loop, it will skip the series if it was not able to fetch its info
| except RequestException as e: | ||
| raise plugin.PluginError('Request error: %s' % str(e)) | ||
| log.error('Request error: %s' % str(e)) # if it fails, just go to next favourite | ||
|
|
There was a problem hiding this comment.
If the error isn't an error, use log.warning
There was a problem hiding this comment.
Ok, technically it is still an error of course; we just decide not to let the whole plugin die on this. But this series will not be fetched any further
There was a problem hiding this comment.
An error is something like unexpected behaviour. If the retry still fails after X tries and you stop the loop, then it's an error. Until then it's expected albeit not ideal behaviour.
There was a problem hiding this comment.
But this is not a loop, if it fails at this point, it is unexpected behaviour and it just stops further processing of this specific series. It moves on to the next series.
There was a problem hiding this comment.
I didn't actually check the context, my bad. It could go either way for me wrt. log level.
There was a problem hiding this comment.
Then I think I'd prefer to put in the error again; I think that is most understandable for the user (and the user probably would want to run the task again)
|
Are there any more changes desired before this could be merged? |
increase the domain delay limit
do not raise a plugin-error on non-critical failed fetches