[fix] Make sqlalchemy 1.1 and 1.2 behave the same. fix #2058#2120
Merged
gazpachoking merged 2 commits intodevelopfrom Apr 11, 2018
Merged
[fix] Make sqlalchemy 1.1 and 1.2 behave the same. fix #2058#2120gazpachoking merged 2 commits intodevelopfrom
gazpachoking merged 2 commits intodevelopfrom
Conversation
Member
Author
|
Codacy, I think you on crack. Nothing is shadowed here, we define a (settable) property, then set that property in |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
SQLAlchemy update to 1.2.0 breaks some stuff for us
Detailed changes:
This change in sqlalchemy 1.2 broke our custom comparators for hybrid properties we were using. Since calling 'comparator' method on hybrid properties no longer mutates the property, we have to re-assign the result back to the property name.
Replaces #2119, fixing the issue at the root.
Addressed issues: