[fix] Renamed site newpct -> descargas 2020 + changes#2093
[fix] Renamed site newpct -> descargas 2020 + changes#2093cvium merged 3 commits intoFlexget:developfrom
Conversation
| if match: | ||
| torrent_id = match.group(2) | ||
| if 'descargas2020.com' in url: | ||
| return (torrent_id.replace('descargar-torrent','download') + '.torrent') |
There was a problem hiding this comment.
Two issues here.
- There should be a space after the comma.
- The outermost parenthesis is unnecessary.
| return (torrent_id.replace('descargar-torrent','download') + '.torrent') | ||
| else: | ||
| response = task.requests.get(torrent_id) | ||
| response = task.requests.get(response.url) |
There was a problem hiding this comment.
I don't like the re-use of variable here. Makes it unclear what's going on. You should at least comment on why you need multiple requests. It also needs a try-except.
There was a problem hiding this comment.
It's because there are redirects. but right now the feed does not work, maybe it's better to remove it for the moment. (It's the "else" for tvsinpagar, the feed is empty actualy)
cvium
left a comment
There was a problem hiding this comment.
Just a few changes required. Looks good otherwise.
|
i have added the clones and fixed the issues. I have removed the code that isn't useful at this moment. All the clones are similar and use the same regexp to extract the torrent. |
|
Is this finished then? |
|
It's working right now. It's finished, at least for me. |
|
Can you update the wiki? |
|
Done. Search and urlrewriter updated, and removed newpct. |
Motivation for changes:
Newpct now is descargas2020 (or tvsinpagar)
Detailed changes: