Use name.utf-8 and path.utf-8 when present#2076
Merged
cvium merged 1 commit intoFlexget:developfrom Feb 5, 2018
Merged
Conversation
cvium
approved these changes
Feb 3, 2018
| name = self.content['info']['name.utf-8'] | ||
| else: | ||
| name = self.content['info']['name'] | ||
| t = {'name': name, |
Contributor
There was a problem hiding this comment.
I think I prefer 'name': self.content['info'].get('name.utf-8') or self.content['info']['name'] or 'name': self.content['info'].get('name.utf-8', self.content['info']['name']), but that's purely a stylistic preference.
Contributor
Author
There was a problem hiding this comment.
My python is limited 😄 it does indeed look cleaner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
I had some crash in bittorent.py when handling torrents that included a directory using Chinese chars.
Looking at others torrent python code (deluge) I see that they use the dictionary keys name.utf-8/path.utf-8 instead of name/path when present.
In the torrent that crashed those keys are present and contains proper utf-8 while path/name contains some bytes that are not UTF-8
Detailed changes:
Addressed issues: