Merged
Conversation
Member
|
You need to recreate the cassettes. Delete all relevant ones from from the cassettes folder under tests and run all tvmaze tests again |
Contributor
Author
|
@liiight I'd like to solicit your guidance on this final failing error. It must be something silly. The error message seems pretty evident but I can't dive deep enough to to figure out this schema error. |
Member
|
Hmm, I'll look into that,hopefully tomorrow. |
d791a6b to
0f26385
Compare
Contributor
Author
|
@liiight The commit I flagged was indeed the culprit. I think something went wrong with my connection during recording. I've rerecorded it. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
The TVMaze API recently started offering an HTTPS endpoint.
Flexget used the wrong query parameters when looking up series on the TVMaze API.
Detailed changes:
BASE_URL._idsuffixes.Addressed issues:
Log and/or tests output (preferably both):
I'll be needing some help here. I'm not sure how to test this properly.