Skip to content

Fix tvmaze api calls#1727

Merged
liiight merged 4 commits intoFlexget:developfrom
haarts:fix-tvmaze-api-calls
Mar 15, 2017
Merged

Fix tvmaze api calls#1727
liiight merged 4 commits intoFlexget:developfrom
haarts:fix-tvmaze-api-calls

Conversation

@haarts
Copy link
Copy Markdown
Contributor

@haarts haarts commented Mar 10, 2017

Motivation for changes:

The TVMaze API recently started offering an HTTPS endpoint.
Flexget used the wrong query parameters when looking up series on the TVMaze API.

Detailed changes:

  • Changed the BASE_URL.
  • Removed the _id suffixes.

Addressed issues:

Log and/or tests output (preferably both):

I'll be needing some help here. I'm not sure how to test this properly.

@liiight
Copy link
Copy Markdown
Member

liiight commented Mar 10, 2017

You need to recreate the cassettes. Delete all relevant ones from from the cassettes folder under tests and run all tvmaze tests again

@haarts
Copy link
Copy Markdown
Contributor Author

haarts commented Mar 13, 2017

@liiight I'd like to solicit your guidance on this final failing error. It must be something silly. The error message seems pretty evident but I can't dive deep enough to to figure out this schema error.
To be frank I think it has something to do with the last commit d791a6b, looking at that diff I see much less Tvmaze API calls than previously.

@liiight
Copy link
Copy Markdown
Member

liiight commented Mar 13, 2017

Hmm, I'll look into that,hopefully tomorrow.

@haarts haarts force-pushed the fix-tvmaze-api-calls branch from d791a6b to 0f26385 Compare March 15, 2017 19:30
@haarts
Copy link
Copy Markdown
Contributor Author

haarts commented Mar 15, 2017

@liiight The commit I flagged was indeed the culprit. I think something went wrong with my connection during recording. I've rerecorded it.
The good news is the tests are all green!

@liiight liiight merged commit d84d5ee into Flexget:develop Mar 15, 2017
@liiight
Copy link
Copy Markdown
Member

liiight commented Mar 15, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tvmaze_lookup fails as URL changed

2 participants