Season packs support - Phase 1 by liiight · Pull Request #1710 · Flexget/Flexget

liiight · 2017-02-26T10:25:45Z

Motivation for changes:

Native season pack support is long overdue. Design

Detailed changes:

Added basic support for season pack type in parser
Added Season table in series DB
Added logical test when tracking series for checking if season pack has been downloaded
Split Release table to EpisodeRelease and SeasonRelease
Added 4 modes for season_packs config: boolean, integer, always and 'only'. These will affect episode threshold control:
By default (or by passing season_packs: yes the default episode threshold will be set to 0, meaning that if a series has 1 or more episode with a downloaded release, a season pack will be rejected.
By passing a specific integer (season_packs: 5 for example), that threshold can be raised.
Setting season_packs: always will always accept the season pack, regardless of how many episodes were already downloaded for the series.
By setting season_packs: only, series plugin will accept only season packs, and reject all episodes.
All modes still abide to checking if season is not completed.
Added lookup by season to api_tvmaze, tvmaze_lookup and est_release_series_tvmaze

Config usage if relevant (new plugin or updated schema):

series:
- foo:
    season_packs: yes
- baz:
    season_packs: 5
- boo:
    season_packs: always
- bla:
    season_packs: only

Existing issues:

Guessit does not support season pack ATM. Its parser will always return False on the is_season_pack call.

To Do:

Create a default threshold that'll check if any existing eps for the season have already been downloaded before accepting season pack.
~~- [ ] Add support for partial season packs (will not mark season as complete)~~ TBD, this does not fit well with the current DB relations and flow
DB Migration. Will do this when DB schema will lock.
More tests.
Edit next_series_episodes to take completed season into account.
Create next_series_seasons
Enable estimators to search for season
Verify no metadata plugins crash.
Fix series CLI

cvium · 2017-02-27T08:59:01Z

flexget/plugins/filter/series.py

+
+    def __eq__(self, other):
+        if not isinstance(other, Season):
+            return NotImplemented


gazpachoking · 2017-03-03T22:48:23Z

With regards to guessit, when it returns type 'episode' with a season, but not an episode number, is that a reliable indication of season pack?

Also, from IRC: Switch (at least by default) to not download season packs once individual episodes have already been downloaded from a given season. Possibly allow an option to define how many individual eps are allowed to be downloaded and still consider getting a full season pack.

liiight · 2017-03-03T23:04:13Z

Dunno about guessit, even if that were to case, I plan to add support for partial season packs (Foo.S01.PART1-Flexget) and that would require explicit support.

@Toilal does guessit have /will have explicit season pack support?

Toilal · 2017-03-04T04:45:25Z

It has support for this Le 4 mars 2017 12:06 AM, "Or Carmi" <notifications@github.com> a écrit :

…

Dunno about guessit, even if that were to case, I plan to add support for partial season packs (Foo.S01.PART1-Flexget) and that would require explicit support. @Toilal <https://github.com/Toilal> does guessit have /will have explicit season pack support? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1710 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHJvpRwU_hwAjGf50GV_UdgzY2TJQvOks5riJzcgaJpZM4MMVOy> .

liiight · 2017-03-04T05:50:04Z

Oh, I guess its a matter of just updating the flexget plugin. You have an open pr for this right?

Toilal · 2017-03-04T06:08:38Z

I'm not sure flexget reads the part property returned by guessit. And yes, it should be updated, I opened a pull request some times ago but 1 or 2 tests was failing and i don't have time to investigate more. Le 4 mars 2017 6:50 AM, "Or Carmi" <notifications@github.com> a écrit :

…

Oh, I guess its a matter of just updating the flexget plugin. You have an open pr for this right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1710 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHJvtYVWJojax9WphK3kWc6RMHILBxCks5riPuNgaJpZM4MMVOy> .

gazpachoking

I like the recent changes. I'm wondering if the logic dealing with comparing seasons to episodes should be more explicitly handled, rather than comparing against an unknown season/entity object. (I'm not sure the way you are doing it is bad though, just a vague notion I had.)

gazpachoking · 2017-03-15T23:12:34Z

flexget/plugins/filter/series.py

+
+    @property
+    def is_season(self):
+        return False


Where are we using the Episode model where we have to ask if it's a season? Also, if this actually makes sense, how about just is_season = False rather than making a property method?

We're using it in a bunch of places actually, like

Flexget/flexget/plugins/filter/series.py

Line 1486 in 5b2988d

for entity, entries in sorted(series_entries.items(), key=lambda e: (e[0].is_season, e[0].season or -1),

What's the benefit of setting a class variable as opposed to a property method?

nm, did it already, pushing soon

gazpachoking · 2017-03-15T23:14:20Z

flexget/plugins/filter/series.py

    def __eq__(self, other):
-        if not isinstance(other, Episode):
-            return NotImplemented
+        if not isinstance(other, (Episode, Season)):


An episode can be equal to a season?

liiight · 2017-03-16T14:05:00Z

I changed a lot of the comparison stuff. A lot of it was just dumb copy paste form Episode. It should make more sense now

…xget/Flexget into season_packs # Conflicts: # flexget/plugins/filter/series.py

tubedogg · 2017-04-02T06:24:14Z

I installed this branch for testing. From my (admittedly limited) testing this is not working with all_series - nothing is being decided upon and there are no series_* fields in the entry dump. Is resolving this within the scope of Phase 1?

(test filename: Show.Name.S02.720p.HDTV.x264-GROUP.torrent)

liiight · 2017-04-02T06:27:09Z

Thanks for testing. Please paste config and debug logs. Admittedly, I did not test this with all_series at all

tubedogg · 2017-04-02T06:39:36Z

Here it is. I should've posted that in the first place, my bad.

Config:

templates:
  watchdir_filesystem_tv:
    filesystem:
      path: "/path/to/torrents/tv"
      mask: '*.torrent'
  watchdir_move:
    move:
      to: '/path/to/torrents/_processed/'
  watchdir_disable:
    disable:
      - seen_info_hash
      - seen

tasks:
  watchdir_tv_eps:
    manual: yes
    template:
      - deluge-connect_tv
      - notify_tv
      - watchdir_disable
      - watchdir_move
      - watchdir_filesystem_tv
    set:
      tracker: tv
      step: 1
      notify_title: 'TV - Watch to Deluge'
    no_entries_ok: yes
    all_series:
      tracking: no
      season_packs: yes

Debug log:
https://gist.github.com/tubedogg/1caeb1cdf3b4949ab4b9d1207a21d111

liiight · 2017-04-02T06:46:22Z

Hmm, looks like it didn't parse that to be a season pack.
Please set the value here to debug and run again.

tubedogg · 2017-04-02T06:55:11Z

The only thing that added to the log was this:

2017-04-02 01:48 DEBUG    seriesparser  watchdir_tv_eps No name for series `Show.Name.S02.720p.HDTV.x264-GROUP` supplied, guessing name.
2017-04-02 01:48 DEBUG    seriesparser  watchdir_tv_eps Could not determine a series name

I think guess_name only tries to match it as an episode, not a season pack, and gives up if it's not an episode.

liiight · 2017-04-02T07:00:13Z

Yeah, i think you're right. Good catch, I'll test and fix soon

liiight · 2017-04-02T07:35:00Z

try now @tubedogg

tubedogg · 2017-04-02T07:47:23Z

@liiight Awesome, works a treat now. 👍 Thanks for doing this - super-excited to finally have season pack support!

liiight · 2017-04-02T07:49:23Z

sure thing. while I have your attention, it'd be great if you could also test next_series_seasons, preferably with real life sites. those scenarios are the hardest to anticipate.

tubedogg · 2017-04-02T08:28:20Z

I modified the BTN search plugin to support season packs and gave it a go withnext_series_seasons. Seems to work great. :)

(For the BTN plugin, do you want me to just tell you what I did and you can include it as part of this PR, or just hold onto it until this is released and submit a PR for BTN?)

liiight · 2017-04-02T08:33:20Z

You can tell me, but it's outside the scope of this pr

tubedogg · 2017-04-02T08:38:45Z

I just put it in a gist, two quick changes. https://gist.github.com/tubedogg/3ae75ab928b8a21fc9b5a51a7cf59ac6

liiight added 5 commits February 22, 2017 16:16

Added initial season pack support to parser

e4c44db

Started adding season pack tracking logic

56103c1

Simple test passing

4a5beaf

Completed basic tracking

2acc79e

Taking into account downloaded season

258b142

cvium reviewed Feb 27, 2017

View reviewed changes

liiight added 8 commits February 27, 2017 11:00

Fixed raising exceptions

32ee2e9

Fixed correct exceptions and logic

e2fe8a6

Fixed comparison issue

9d803cb

Made season pack respect tracking rules

3019a90

Added more tests

667c5e3

Added season pack format

2f8efe9

Added test

2fd35da

Added backfill test

215f10c

liiight requested review from gazpachoking and paranoidi March 1, 2017 09:15

liiight added 3 commits March 13, 2017 15:27

Split releases table into episode_releases and season_releases

71b16e2

typo

fa84b70

Added episode threshold verification

5b2988d

gazpachoking reviewed Mar 16, 2017

View reviewed changes

liiight added 4 commits March 16, 2017 12:53

Fixed bug with threshold and begin episode

2f707a2

Fixed backfill logic

7808b80

Added ep threshold tests

af21a6d

Tweaked comparison

f1b9e25

liiight added 5 commits March 26, 2017 12:47

Set entity tyoe in next plugins

623b461

Made season pack schema more flexible

c362dd7

Fixed test cassettes and logic

ea9d6bb

Fixed test cassettes

51ce8be

more vcr crap

416459b

liiight mentioned this pull request Mar 28, 2017

Request: Please introduce season pack downloading #948

Closed

liiight added 4 commits March 28, 2017 14:34

Merge branches 'develop' and 'season_packs' of https://github.com/Fle…

6f2b332

…xget/Flexget into season_packs # Conflicts: # flexget/plugins/filter/series.py

Merge branches 'develop' and 'season_packs' of https://github.com/Fle…

015754e

…xget/Flexget into season_packs # Conflicts: # flexget/plugins/filter/series.py

Fixed series list cli

1696d9e

Fixed series show cli

28e0fd7

liiight added 3 commits April 2, 2017 10:33

Correctly returning db version

2b19e53

Added tests for proper season pack

6769975

Added season packs parse to guess name method

1dc0f6e

Removed false positive test

d2dd94e

Fixed next_series_seasons rerun logic

f120883

liiight merged commit f104523 into develop Apr 3, 2017

liiight deleted the season_packs branch April 9, 2017 15:30

andocromn mentioned this pull request Oct 12, 2017

Rejecting episode because detected as season pack #1986

Closed

Conversation

liiight commented Feb 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for changes:

Detailed changes:

Config usage if relevant (new plugin or updated schema):

Existing issues:

To Do:

Uh oh!

cvium Feb 27, 2017

Choose a reason for hiding this comment

Uh oh!

liiight Feb 27, 2017

Choose a reason for hiding this comment

Uh oh!

gazpachoking commented Mar 3, 2017

Uh oh!

liiight commented Mar 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Toilal commented Mar 4, 2017 via email

Uh oh!

liiight commented Mar 4, 2017

Uh oh!

Toilal commented Mar 4, 2017 via email

Uh oh!

gazpachoking left a comment

Choose a reason for hiding this comment

Uh oh!

gazpachoking Mar 15, 2017

Choose a reason for hiding this comment

Uh oh!

liiight Mar 16, 2017

Choose a reason for hiding this comment

Uh oh!

liiight Mar 16, 2017

Choose a reason for hiding this comment

Uh oh!

gazpachoking Mar 15, 2017

Choose a reason for hiding this comment

Uh oh!

liiight commented Mar 16, 2017

Uh oh!

tubedogg commented Apr 2, 2017

Uh oh!

liiight commented Apr 2, 2017

Uh oh!

tubedogg commented Apr 2, 2017

Uh oh!

liiight commented Apr 2, 2017

Uh oh!

tubedogg commented Apr 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liiight commented Apr 2, 2017

Uh oh!

liiight commented Apr 2, 2017

Uh oh!

tubedogg commented Apr 2, 2017

Uh oh!

liiight commented Apr 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tubedogg commented Apr 2, 2017

Uh oh!

liiight commented Apr 2, 2017

Uh oh!

tubedogg commented Apr 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

liiight commented Feb 26, 2017 •

edited

Loading

liiight commented Mar 3, 2017 •

edited

Loading

tubedogg commented Apr 2, 2017 •

edited

Loading

liiight commented Apr 2, 2017 •

edited

Loading