rutracker - always use https#1703
Merged
liiight merged 3 commits intoFlexget:developfrom Feb 21, 2017
Danfocus:Danfocus-patch-rutracker-2
Merged
rutracker - always use https#1703liiight merged 3 commits intoFlexget:developfrom Danfocus:Danfocus-patch-rutracker-2
liiight merged 3 commits intoFlexget:developfrom
Danfocus:Danfocus-patch-rutracker-2
Conversation
Member
|
Why make it optional? Why not always use https? |
Contributor
Author
I check now - rutracker always redirect to https. |
cvium
reviewed
Feb 21, 2017
|
|
||
| class RutrackerAuth(AuthBase): | ||
| """Supports downloading of torrents from 'rutracker' tracker | ||
| if you pass cookies (CookieJar) to constructor then authentication will be bypassed and cookies will be just set |
Contributor
There was a problem hiding this comment.
This line doesn't look longer than 120 chars, so why the linebreak?
cvium
reviewed
Feb 21, 2017
flexget/plugins/sites/rutracker.py
Outdated
| for entry in task.accepted: | ||
| if entry['url'].startswith('http://rutracker.org/forum/viewtopic.php'): | ||
| if entry['url'].startswith( | ||
| '{}/forum/viewtopic.php'.format(BASE_URL)): |
Contributor
There was a problem hiding this comment.
Same here. Another weird linebreak.
cvium
reviewed
Feb 21, 2017
flexget/plugins/sites/rutracker.py
Outdated
| @@ -95,15 +98,17 @@ def __init__(self, login, password, cookies=None, db_session=None): | |||
| def __call__(self, r): | |||
| url = r.url | |||
| id = re.findall(r'\d+', url)[0] | |||
Contributor
There was a problem hiding this comment.
While you're already in there, you should change this variable name to something other than id.
Contributor
Author
There was a problem hiding this comment.
change to t_id (thread_id)
Contributor
Author
|
Changes are made |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Sometimes rutracker.org available only throw https
Detailed changes:
Addressed issues:
Config usage if relevant (new plugin or updated schema):
Log and/or tests output (preferably both):