Escape tvmaze URL query parameters#1699
Merged
liiight merged 1 commit intoFlexget:developfrom Feb 18, 2017
pkoenig10:pkoenig/urlencode
Merged
Escape tvmaze URL query parameters#1699liiight merged 1 commit intoFlexget:developfrom pkoenig10:pkoenig/urlencode
liiight merged 1 commit intoFlexget:developfrom
pkoenig10:pkoenig/urlencode
Conversation
Member
|
Very nice, thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
When searching for shows using the TVmaze API, Flexget does not escape any query parameters. This leads to incorrect searches. My log file showing the error is linked below. You can see that Flexget attempted to search for "Law & Order: Special Victims Unit", but the "&" was not escaped. If you go to the requested URL you will see that the received search term was just "Law", resulting in the plugin returning Newton's Law instead of Law & Order SVU.
Detailed changes:
Log output:
https://gist.github.com/anonymous/460c9231e44062b6ce0d9c354fbc6ea4