Conversation
|
Much improved, +1 |
|
I think there's a potential issue. What if a |
Not quite sure what you mean by "a task is defined under entries", but yes, task notifications will be sent once per rerun. I don't think that behavior has changed though, and don't really see a way around it. |
|
Sorry I meant task configured under notify, you got the idea. |
Sure, but that you'll only get notified about entries in the last rerun of the task, which I think is even less desirable than multiple notifications. |
|
To do proper combined emails you sorta need a digesting task (at the moment.) |
|
Well I guess it's out of the scope of this, but aggregating entries in different reruns would be nice. I see no other reason not to merge this then. |
Motivation for changes:
Notify phase was added to enable plugins that don't end up propagating errors to task. We since combined all notify plugins into one master 'notify' plugin, which means there is already a common place to catch the errors without a special phase.
Detailed changes:
Addressed issues: