Make sure series_name_plain is really plain#1611
Merged
cvium merged 1 commit intoFlexget:developfrom Jan 5, 2017
mfonville:develop
Merged
Make sure series_name_plain is really plain#1611cvium merged 1 commit intoFlexget:developfrom mfonville:develop
cvium merged 1 commit intoFlexget:developfrom
mfonville:develop
Conversation
Contributor
|
Looks like you forgot to update it in a few places. |
Contributor
Author
|
Ah, whoops, I thought I had them all. I will update the commit/PR OK; apparently my current PR gave a lot of trouble with python3; I have now updated the function to be more in line with the original design, just adding an extra check against 'Punction'-category of unicode |
Needs to remove also some special character processing to produce filesystem-safe strings
Contributor
Author
|
@cvium it should now be ok :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to remove also some special character processing to produce filesystem-safe strings
Motivation for changes:
Current series_name_plain produced outputs that are unprocessable on e.g. Windows filesystems or Samba shares; for passing a better value to
download-npoa further processed plain string is more practicalDetailed changes:
_strip_accentsfunction into a_convert_plainfunction