add missing movie_metainfo, series_metainfo property's#1610
add missing movie_metainfo, series_metainfo property's#1610liiight merged 1 commit intoFlexget:developfrom Andy2244:series_metainfo
Conversation
|
Regarding this logic, i noticed a small problem. If a metainfo plugin supports multiple id's and no actual plugin for those id's exist than the field name is not retrieved. Example: So maybe there should be a extra property or additional list, tuple return of all possible supported id fields. So that we can always get a complete list of all id fields for each category per plugin. Maybe like this? or |
|
What metainfo plugin has multiple ids? And tvrage isn't returned because we don't have a tvrage plugin anymore |
|
tvmaze has support for: So in most cases the remote api's actually support multiple id lookups and also return multiple id's, even if not currently implemented in the plugins. In my case i wanted to get all possible series id fields that can be used to identify a series and as noted i still have to hardcode |
|
The idea of this identifier is to have one main identifier per metainfo plugin type which can then be used in various places (like validate allowed values for examples). While obviously the vast majority of plugins return multiple identifiers per successful lookup, it's not relevant for this usage. |
|
I understand this and by hardcode i mean you need to-do something like this atm. I simply thought that adding the ability to get a list of all supported id fields per plugin might be a good enhancement. So you could search for a meta plugin based on a given id field. Lets say a entry has a tvrage_id and now you want to know what meta lookup plugins could be used for a lookup. |
|
The whole point of this feature was to dynamically add support for identifiers via our existing lookup plugins. Anything else is outside the scope of this |
Motivation for changes:
Some plugins did not support the movie_metainfo, series_metainfo group tag/property.
Detailed changes:
added movie_metainfo to rottentomatoes_lookup
added series_metainfo to thetvdb_lookup, tvmaze_lookup