Skip to content

Upgrade of 'secrets' plugin to 'variables'#1579

Merged
gazpachoking merged 7 commits intonextfrom
config_variables
Dec 21, 2016
Merged

Upgrade of 'secrets' plugin to 'variables'#1579
gazpachoking merged 7 commits intonextfrom
config_variables

Conversation

@gazpachoking
Copy link
Copy Markdown
Member

Motivation for changes:

There were some conflicts with secrets plugin when jinja was being used in the config (#1578). The name 'secrets' also seemed too limited for what was possible with the plugin.

Detailed changes:

  • Renames the 'secrets' plugin to 'variables'
  • Changes jinja tag to {? ?} for replacement to avoid conflicts with jinja in the config
  • Removes the need for the 'secrets' prefix on every variable

Addressed issues:

Config usage if relevant (new plugin or updated schema):

  • Root level 'secrets' in config will need to be renamed to 'variables'.
  • Any use of secrets in the config will need to have the surrounding tags replaced with {? ?} and remove the reference to 'secrets'. e.g.: {{ secrets.username }} becomes {? username ?}

Changes jinja tag to {? ?} for replacement to avoid conflicts with jinja in the config
@gazpachoking gazpachoking changed the base branch from next to develop December 19, 2016 23:40
@gazpachoking gazpachoking changed the base branch from develop to next December 19, 2016 23:40
@gazpachoking gazpachoking merged commit ceffc1e into next Dec 21, 2016
@gazpachoking
Copy link
Copy Markdown
Member Author

Started the wiki page upgrade at https://flexget.com/Plugins/variables We'll need to point secrets page there once this goes live.

@gazpachoking gazpachoking deleted the config_variables branch December 23, 2016 17:43
@liiight liiight mentioned this pull request Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants