Preserve torrents based on presence of trackers#1482
Preserve torrents based on presence of trackers#1482liiight merged 2 commits intoFlexget:developfrom
Conversation
|
My first reaction is that I don't really like the current design of clean_transmission, and think we should move to a system where it can live in its own task with from_transmission input, and use normal filter plugins on that task to control what it cleans. The current model only begets this sort of option adding for internal filtering. That being said, I'm not sure if that should hold up this PR or not. |
| (is_torrent_seed_only and is_torrent_idlelimit_since_added_reached) or | ||
| (not is_torrent_seed_only and is_torrent_idlelimit_since_finished_reached)) | ||
| and is_tracker_matching and is_directories_matching): | ||
| and is_directories_matching (not is_preserve_tracker_matching and is_tracker_matching)): |
There was a problem hiding this comment.
and is_directories_matching (not is_preserve_tracker_matching and is_tracker_matching)
is there meant to be an 'and' or an 'or' in between is_directories_matching and that parenthetical?
| (is_torrent_seed_only and is_torrent_idlelimit_since_added_reached) or | ||
| (not is_torrent_seed_only and is_torrent_idlelimit_since_finished_reached)) | ||
| and is_tracker_matching and is_directories_matching): | ||
| and is_directories_matching and (not is_preserve_tracker_matching and is_tracker_matching)): |
There was a problem hiding this comment.
There's no need for that parenthesis.
|
I don't think it makes sense to not allow these kinds of PRs. Small changes that improve QoL. Should Transmission plugins be refactored completely? Yes, but that's quite a daunting task for most, so who's to say when and if that will happen. |
|
Like we discussed in gitter, I'm @gazpachoking on this one. I think that any feature that is added to the current state of this plugin will just deter any work on modifying it. |
|
I think thes feature is awesome i do download form alot of place but I only and to keep torrents from 2 or 3 trackers |
Motivation for changes:
Forum discussion about skipping cleanup for certain torrents based on the presence of a tracker in the torrent's tracker list
Detailed changes:
Creation of a new config setting "preserve_tracker" and adding corresponding logic
Addressed issues:
None
Config usage if relevant (new plugin or updated schema):
clean_transmission:
host: localhost
port: 9091
username: myusername
password: mypassword
tracker: nyaa|animebytes
preserve_tracker: alpharatio|what