support size unit of "B". if sizes doesn't match log and ignore.#1441
Merged
cvium merged 3 commits intoFlexget:developfrom Oct 13, 2016
lostsubstance:patch-1
Merged
support size unit of "B". if sizes doesn't match log and ignore.#1441cvium merged 3 commits intoFlexget:developfrom lostsubstance:patch-1
cvium merged 3 commits intoFlexget:developfrom
lostsubstance:patch-1
Conversation
some results were so small they reported bytes and the regex didn't match. this makes missed parses of size not trigger an exception. as well as supporting Bytes.
cvium
reviewed
Oct 11, 2016
flexget/plugins/sites/piratebay.py
Outdated
| if size: | ||
| entry['content_size'] = parse_filesize(size.group(1)) | ||
| else: | ||
| log.error('Malformed search result? Title: "%s", No size? %s' % (entry['title'], sizeText)) |
Contributor
There was a problem hiding this comment.
Let the logger handle string formatting. Use a comma instead of %
cvium
reviewed
Oct 12, 2016
flexget/plugins/sites/piratebay.py
Outdated
| entry['content_size'] = parse_filesize(size.group(1)) | ||
| else: | ||
| log.error('Malformed search result? Title: "%s", No size? %s' % (entry['title'], sizeText)) | ||
| log.error('Malformed search result? Title: "%s", No size? %s', (entry['title'], sizeText)) |
Contributor
There was a problem hiding this comment.
That's not gonna work. You need to remove the parenthesis around the variables. This is gonna crash since you're passing a tuple.
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some results were so small they reported bytes and the regex didn't match. (resulting in an exception being thrown) This makes missed parses of size not trigger an exception, as well as supporting Bytes.