Change config hash to use pprint#1411
Merged
cvium merged 6 commits intoFlexget:developfrom Sep 18, 2016
Merged
Conversation
liiight
approved these changes
Sep 18, 2016
flexget/task.py
Outdated
| from flexget.utils.cached_input import get_config_hash | ||
| from flexget.utils.database import with_session | ||
| from flexget.utils.simple_persistence import SimpleTaskPersistence | ||
| from flexget.utils.tools import merge_dict_from_to |
Member
There was a problem hiding this comment.
I know this isn't your name but can we change merge_dict_from_to to something like dict_merge? that name is horrible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Current method for hashing the config falls apart when the config is nested dicts.
Detailed changes:
Related issues