Skip to content

Fix pyload plugin#1391

Merged
cvium merged 2 commits intoFlexget:developfrom
cvium:fix_pyload
Sep 13, 2016
Merged

Fix pyload plugin#1391
cvium merged 2 commits intoFlexget:developfrom
cvium:fix_pyload

Conversation

@cvium
Copy link
Copy Markdown
Contributor

@cvium cvium commented Sep 6, 2016

Motivation for changes:

Beats me

Detailed changes:

  • Messy plugin. Tried making it prettier/better.
  • Use json.dumps to make sure every post parameter is properly formatted.
  • Changed the schema to make sense (pyload: yes???)

Addressed issues:

@Roburetto
Copy link
Copy Markdown

Roburetto commented Sep 11, 2016

I may have found an issue, related with this particular commit or perhaps prior.

The thing is, while using parse_url most hosters have their urls correctly identified but not MegaCoNz.

I really know nothing of Python, but it may be related with the particular way the class is defined.

My Flexget config (use the same with other hosters and it works fine):

      queue: yes
      parse_url: yes
      hoster: 
        - MegaCoNz
      multiple_hoster: no
      enabled: yes

@cvium
Copy link
Copy Markdown
Contributor Author

cvium commented Sep 11, 2016

This particular "commit" is a PR that has not been merged, so unless you're actually using this, this is the wrong place.

@Roburetto
Copy link
Copy Markdown

Roburetto commented Sep 11, 2016

I am using it. I downloaded and replaced the original file.

@cvium
Copy link
Copy Markdown
Contributor Author

cvium commented Sep 12, 2016

I don't agree with his assessment. https://github.com/pyload/pyload/wiki/module.Api.Api

Parses html content or any arbitaty text for links and returns result of checkURLs

That is what we use.

@Roburetto
Copy link
Copy Markdown

Roburetto commented Sep 12, 2016

OK. Thanks for confirming that. I will return the issue to PyLoad. then.

EDIT: I have now confirmed it was indeed an issue with PyLoad code as described here.

@cvium cvium merged commit e71f942 into Flexget:develop Sep 13, 2016
@cvium cvium mentioned this pull request Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants