Merged
Conversation
…empted to verify a succesful login. There was something wrong with the character set of the myepisodes page preventing it from working. I added an explicit translation of the return page to fix it.
Contributor
|
I think it would be better to refactor that plugin to use requests (http://docs.python-requests.org/en/master/) instead. |
…ome of the larger methods into more readable pieces. Updated the URLs being used. They we incorrect in some cases and the authentication was not being done over SSL.
Contributor
Author
|
I refactored to requests as suggested, but now the CI build is failing. I'm Not sure what happened. |
| self.http_session = self._login(config) | ||
|
|
||
| except plugin.PluginWarning as w: | ||
| log.warning(str(w)) |
Contributor
There was a problem hiding this comment.
No need to use str(). It will do the conversion for you.
Contributor
Author
There was a problem hiding this comment.
I will update all of these. There are a few.
… converting exceptions with str() when logging. Added unicode compatibility import back in. Removed a , cough, semi-colon. Minor PEP8 compliance changes.
|
|
||
|
|
||
| try: | ||
| from flexget.plugins.internal.api_tvdb import lookup_series |
Contributor
There was a problem hiding this comment.
Should remove this import and use plugin.get_plugin_by_name('api_tvdb').instance.lookup_series where applicable instead. It will raise a dependencyerror if it's not found.
Member
|
any progress on this? |
…_tvdb').instance.lookup_series instead
Contributor
|
I don't remember anything about this PR, but all my comments seem to have been addressed. Good work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Flexget was bombing when it attempted to verify a succesful login to the myepisodes.com website
Detailed changes: