Merged
Conversation
Discovered by writing the formlogin.html file in binary mode no TypeError is generated. Also tested that if the fields were named their default username and password this problem doesn't occur it is only when it fails and creates the html file.
flexget/plugins/plugin_formlogin.py
Outdated
| os.mkdir(received) | ||
| filename = os.path.join(received, '%s.formlogin.html' % task.name) | ||
| with open(filename, 'w') as f: | ||
| with open(filename, 'wb') as f: |
Contributor
There was a problem hiding this comment.
Might as well change it to use io.open instead imo.
Author
|
As per your suggestion @cvium it has now been updated to use io.open. |
Member
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
When the default fields on a web form aren't
usernameorpasswordthe resulting HTML file the plugin tries to write generates the following error.Detailed changes:
Addressed issues: