Skip to content

Reorder Quality plugin#1342

Merged
cvium merged 8 commits intoFlexget:developfrom
cvium:quality_priority
Aug 30, 2016
Merged

Reorder Quality plugin#1342
cvium merged 8 commits intoFlexget:developfrom
cvium:quality_priority

Conversation

@cvium
Copy link
Copy Markdown
Contributor

@cvium cvium commented Aug 16, 2016 •
edited
Loading

Motivation for changes:

Sometimes I disagree with quality priorities for some sites. With this plugin I can change the ordering.

Detailed changes:

  • Added plugin and one test to make sure it sets value at task start and restores original value at task exit/abort

Config usage if relevant (new plugin or updated schema):

reorder_quality:
  webrip:
    above: hdtv

@liiight
Copy link
Copy Markdown
Member

liiight commented Aug 16, 2016

Thus requires knowing the value for each quality component, doesn't it? That's not very user friendly imo

@cvium
Copy link
Copy Markdown
Contributor Author

cvium commented Aug 16, 2016

Same can be said for plugin_priority

@liiight
Copy link
Copy Markdown
Member

liiight commented Aug 16, 2016

yep, i agree. That one sucks too. Doesn't mean we should perpetuate it.

@cvium
Copy link
Copy Markdown
Contributor Author

cvium commented Aug 16, 2016

Going to reopen against develop later.

@cvium cvium closed this Aug 16, 2016
@cvium cvium reopened this Aug 17, 2016
@cvium cvium changed the base branch from next to develop August 17, 2016 08:54
@cvium cvium force-pushed the quality_priority branch from 4c176c1 to 36a6072 Compare August 17, 2016 13:00
@cvium cvium changed the title Quality priority plugin Reorder Quality plugin Aug 30, 2016
@cvium cvium merged commit 865a9ff into Flexget:develop Aug 30, 2016
@grr
Copy link
Copy Markdown

grr commented Aug 30, 2016

Thus requires knowing the value for each quality component, doesn't it? That's not very user friendly imo

couldn't manipulate plugin be used to swap the qualities to accomplish the same thing? i.e. if hdtv is found, replace with webrip, and vice versa.

@cvium cvium deleted the quality_priority branch August 30, 2016 14:02
@liiight
Copy link
Copy Markdown
Member

liiight commented Aug 30, 2016

This plugin doesn't manipulate entry quality, it enables overriding the hard coded quality component values to create custom comparisons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cvium @liiight @grr