Fix wrong umask calculation in download test#1338
Merged
cvium merged 1 commit intoFlexget:developfrom Aug 15, 2016
Merged
Conversation
Contributor
|
Is it only the test or also in the download plugin itself? |
Contributor
Author
|
Very likely only the test, since it passes with my umask of 077 after the fix without changing the implementation at all. |
Contributor
|
Alright, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculating the umask by subtraction only works by coincidence in some cases. The correct way is to use bitwise operations to unset any bits in the umask from the expected permissions. I found this since I run with
umask 077and the test always failed on my system.