Fixed Codacy issue.

Do all providers need/have relevant config options?
Also, do you think it'll be possible to define a provider directly under root level without needing the providers_config property?

Do all providers need/have relevant config options?

Currently only those that need authentication.

Also, do you think it'll be possible to define a provider directly under root level without needing the providers_config property?

I commented about that in the commit: using only the providers key would make it impossible to set options for some plugins without disabling all the others. An alternative would be to allow a boolean instead of a dictionary for plugins that don't need configuration.

subliminal:
  providers:
    legendastv:
      username: myuser
      password: mypassword
    opensubtitles: yes

It would still not cover the case of omitting providers altogether and fetching from all the providers available. Would having an all key be better?

subliminal:
  providers:
    all: yes
    legendastv:
      username: myuser
      password: mypassword

Which would pass a providers_list of None but have the legendastv key in provider_configs.

Couldn't you just do this:

subliminal:
  providers:
    legendastv:
      username: myuser
      password: mypassword

@cvium I just edited my comment above to explain why not.

You could set type to be object or string, then check in code :
'type':['object', 'string'].
If that's not possible I guess leaving it as is is ok.
I think naming the option something like authentication would be better but that's just a suggestion.

@liiight I don't think there is any specification that the configs will always be for authentication - it just happens to be the current situation. Using only the providers key does seem cleaner, but the all workaround is quite ugly. Is there any other plugin with a similar situation that we can use as a model?

'providers': {'type': 'array', 'items': {
    'oneOf': [
        {'type': 'object',
        'additionalProperties': {
            'type': 'object',
            'properties': {
                'username': {'type': 'string'},
                'password': {'type': 'string'},
            }
        }},
        {'type': 'string'}
    ]
}},

The above will let you do this:

    subliminal:
      providers:
        - legendastv:
            username: myuser
            password: mypassword
        - opensubtitles

@cvium That looks really nice. But what about the option of enabling all available providers? edit: Would an all_providers: yes option be good?

I think I prefer having provider_configs

What about this:

providers:
  all: yes
  configs: 
    legendastv:
      username: myuser
      password: mypassword

For the case of keeping all providers and configuring some. @cvium's last suggestion would also work.

Nay for provider_configs from me, looks like nothing we have currently.

Perhaps call the key authentication or login and it makes a lot more sense. I don't think there will be anything else in there?

Any progress on this?

I've renamed the configuration key from provider_configs to authentication and rebased to the latest of the develop branch.

Other than some PEP8 issues it looks fine.

Would it be preferable to fix the issues in an extra commit or just amend the previous ones?

Another commit is fine

Done.

I don't know what's wrong with Codacy, it shows no issues with the commit but fails anyway.

We had miscommunication so our codacy account got deleted along with its config. We have yet to reconfigure the new one.

I update the Wiki page with the new additions. Thanks a lot!