Merged
Conversation
Comment on lines
-37
to
-38
| 'url': {'type': 'string', 'format': 'url'}, | ||
| 'website': {'type': 'string', 'format': 'url'}, |
Member
There was a problem hiding this comment.
I think better to keep the old properties, then add the oneOf up a level like:
oneOf: [{'required': 'url'}, {'required': 'website'}]
Contributor
Author
There was a problem hiding this comment.
Good idea. Didn't know you could do that.
Member
|
Looks good to me! Thanks! That error on python 3.11 isn't to do with your change, I think it's a python 3.11.4 difference that just started showing up. Should go away on merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Fix issue where newznab plugin loses the API key and category on successive searches.
Detailed changes: